Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use fresh pipelines rather than linker pipeline #2062

Closed
wants to merge 7 commits into from

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Mar 15, 2024

WIP

@RobinL RobinL changed the base branch from master to splink4_dev March 15, 2024 09:02
@@ -535,6 +535,17 @@ def _initialise_df_concat_with_tf(self, materialise=True):

return nodes_with_tf

def _enqueue_df_concat_with_tf(self, pipeline: SQLPipeline):
Copy link
Member Author

@RobinL RobinL Mar 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no good because it doesn't deal with the cache

This is really fiddly because either:

  • You want to execute the pipeline, add it to the cache and return the dataframe
  • Retrieve from the cache if exists
  • Return a pipeilne with the right sqls enqueued

So there's not an easy version of this that uses a fresh sql pipeline. you can pass one in, but then uncear what to return

Another option would be to allow the pipeline to queue input dataframes, tha seems promising ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case, a fresh sql pipeline is passed in. If it's in the cache, then the pipeline is returned with it as an input dataframe queued up

if it's not in the cache either

  • materialisation case: a pipeline is returned with it in the cache
  • non-materialisation case: a pipeline is returned with sql enqueued

@RobinL RobinL closed this Mar 16, 2024
@RobinL RobinL deleted the use_fresh_pipelines branch August 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant